Code review comment for lp:~ben-mendis/wicd/fix-exit-status
Revision history for this message
| Pieter Leclerc (pieterleclerc-deactivatedaccount) wrote | # |
review:
Approve
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Tested.
Some comments (a list of the exit codes) would have been nice, and the output (always "done!") is not consistent with the exit code (0 or 6), but it is an improvement over the status quo so I've merged it already. Keep those improvements coming!