Code review comment for lp:~ben-hutchings/endroid/roomowner

Revision history for this message
Martin Morrison (isoschiz) wrote :

Comments in the order the files appear in the diff:

src/endroid/__init__.py

- You've changed permissions on this file. Please revert! It shouldn't be executable

- In general, it's nice to keep the module name on foreign imports (e.g. things that come from twisted). "service.Application" is a lot more obvious than "Application". Revert that import in particular.

- Probably want to increment the version number of EnDroid. ;-)

- The fields on EnDroid itself are clearer in full: rosterhandler, wokkelhandler, messagehandler, usermanagement (rather than rh, wh, um, mh).

- The initialisation code has changed - although a lot of it appears to just be changes to the names of local variables, and not to functionality. Can you revert the lines that are unchanged, to make it easier to review.

(more comments to come)

« Back to merge proposal