Merge lp:~ben-blankley/testdrive/fix-940755 into lp:testdrive

Proposed by Ben Blankley
Status: Merged
Merge reported by: Jackson Doak
Merged at revision: not available
Proposed branch: lp:~ben-blankley/testdrive/fix-940755
Merge into: lp:testdrive
Diff against target: 11 lines (+1/-0)
1 file modified
testdrive/virt/virtualbox.py (+1/-0)
To merge this branch: bzr merge lp:~ben-blankley/testdrive/fix-940755
Reviewer Review Type Date Requested Status
Jackson Doak Approve
Review via email: mp+186470@code.launchpad.net

Description of the change

Fixed PAE error when using VirtualBox to test ISOs by setting the VirtualBox PAE option on.

To post a comment you must log in.
Revision history for this message
Jackson Doak (noskcaj) wrote :

Looks good. I'll let dustin or andres do the final merge since i don't think they trust me yet.

review: Approve
Revision history for this message
Ben Blankley (ben-blankley) wrote :

> Looks good. I'll let dustin or andres do the final merge since i don't think
> they trust me yet.

Do I have to add them as reviewers on the merge request, or does Launchpad do that automatically? Thanks.

Revision history for this message
Jackson Doak (noskcaj) wrote :

It notifies them too. really you shouldn't have to request a review
because the whole testdrive team sees it.

On Fri, Sep 20, 2013 at 4:07 AM, Ben Blankley <email address hidden> wrote:
>> Looks good. I'll let dustin or andres do the final merge since i don't think
>> they trust me yet.
>
> Do I have to add them as reviewers on the merge request, or does Launchpad do that automatically? Thanks.
> --
> https://code.launchpad.net/~ben-blankley/testdrive/fix-940755/+merge/186470
> You are reviewing the proposed merge of lp:~ben-blankley/testdrive/fix-940755 into lp:testdrive.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'testdrive/virt/virtualbox.py'
--- testdrive/virt/virtualbox.py 2013-08-10 20:52:38 +0000
+++ testdrive/virt/virtualbox.py 2013-09-19 06:17:28 +0000
@@ -86,6 +86,7 @@
86 self.run_or_die("VBoxManage modifyvm %s --boot1 disk" % self.VBOX_NAME)86 self.run_or_die("VBoxManage modifyvm %s --boot1 disk" % self.VBOX_NAME)
87 self.run_or_die("VBoxManage modifyvm %s --boot2 dvd" % self.VBOX_NAME)87 self.run_or_die("VBoxManage modifyvm %s --boot2 dvd" % self.VBOX_NAME)
88 self.run_or_die("VBoxManage modifyvm %s --nic1 nat" % self.VBOX_NAME)88 self.run_or_die("VBoxManage modifyvm %s --nic1 nat" % self.VBOX_NAME)
89 self.run_or_die("VBoxManage modifyvm %s --pae on" % self.VBOX_NAME)
8990
90 # Code launch virtual machine91 # Code launch virtual machine
91 def launch_virt(self):92 def launch_virt(self):

Subscribers

People subscribed via source and target branches