Xiphos

Code review comment for lp:~bdrung/xiphos/lintian-clean

  1. lintian-clean
  2. Merge into main
Revision history for this message
Benjamin Drung (bdrung) wrote :

Am Samstag, den 12.09.2009, 01:36 +0000 schrieb Jonathan Marsden:
> Congratulations on becoming a MOTU,

Thanks.

> and thanks for your interest in
> Xiphos. This diff is really *huge*, and as far as I can see, Xiphos
> 3.1.1-2 is already lintian clean in Debian Unstable and in Debian
> Testing. See http://packages.qa.debian.org/xiphos and note the absence
> of any Lintian warnings there. Is that level of cleanliness now
> insufficient for Ubuntu?
>
> Can you please explain exactly how "lintian unclean" Xiphos really is in
> its current state, which Lintian version on which Ubuntu (or Debian)
> release you are testing it with, and why it apparently needs such a
> large diff to clean it up?

I get following report from lintian -iIE --pedantic (version 2.2.14,
build on jaunty):
P: xiphos: copyright-refers-to-symlink-license usr/share/common-licenses/GFDL
W: xiphos: binary-or-shlib-defines-rpath ./usr/bin/xiphos /usr/lib
W: xiphos: binary-or-shlib-defines-rpath ./usr/bin/xiphos /lib
P: xiphos-data: copyright-refers-to-symlink-license usr/share/common-licenses/GFDL
P: gnomesword: copyright-refers-to-symlink-license usr/share/common-licenses/GFDL

My changes are not huge. The problem is the 2.3 MiB big auto-generated
patch. Attached the diff with this patch trimmed down. Then the changes
are only 60 lines long.

Cheers,
Benjamin

xiphos.patch
1diff -pruN orig/debian/copyright main/debian/copyright
2--- orig/debian/copyright 2009-09-12 10:08:25.500267233 +0200
3+++ main/debian/copyright 2009-09-10 16:26:26.275774693 +0200
4@@ -1,19 +1,33 @@
5-Format-Specification: http://wiki.debian.org/Proposals/CopyrightFormat?action=recall&rev=428
6-Upstream-Name: Xiphos
7-Upstream-Maintainer: The Gnomesword Developer Team <gnomesword-developers@lists.sourceforge.net>
8-Upstream-Source: http://www.xiphos.org
9+Format-Specification: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=59
10+Name: Xiphos
11+Maintainer: The Gnomesword Developer Team <gnomesword-developers@lists.sourceforge.net>
12+Source: http://www.xiphos.org
13
14 Files: *
15 Copyright: Copyright 2000-2008, Xiphos Developer Team
16 License: GPL-2+
17- On Debian systems the full text of the GNU General Public License can be found
18- in the `/usr/share/common-licenses/GPL-2' file.
19+ This program is free software; you can redistribute it and/or modify
20+ it under the terms of the GNU General Public License as published by
21+ the Free Software Foundation; either version 2 of the License, or
22+ (at your option) any later version.
23+ .
24+ This package is distributed in the hope that it will be useful,
25+ but WITHOUT ANY WARRANTY; without even the implied warranty of
26+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
27+ GNU General Public License for more details.
28+ .
29+ You should have received a copy of the GNU General Public License along
30+ with this package; if not, write to the Free Software Foundation, Inc.,
31+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
32+ .
33+ On Debian systems the full text of the GNU General Public License
34+ can be found in the `/usr/share/common-licenses/GPL-2' file.
35
36 Files: help/*
37 Copyright: Copyright 2003-2009, The Xiphos Team
38 License: GFDL-1.1+
39- On Debian systems the full text of the GNU Free Documentation License can be found
40- in the `/usr/share/common-licenses/GFDL' file.
41+ On Debian systems the full text of the GNU Free Documentation License
42+ can be found in the `/usr/share/common-licenses/GFDL-1.2' file.
43
44 Files: debian/*
45 Copyright: Copyright 2009, Crosswire Packaging Team <pkg-crosswire-devel@lists.alioth.debian.org>
46diff -pruN orig/debian/patches/autoreconf.patch main/debian/patches/autoreconf.patch
47--- orig/debian/patches/autoreconf.patch 1970-01-01 01:00:00.000000000 +0100
48+++ main/debian/patches/autoreconf.patch 2009-09-12 10:24:50.649434412 +0200
49@@ -0,0 +1,3 @@
50+Update the autotools files to get rid of the binary-or-shlib-defines-rpath lintian warning.
51+This patch is created by running "autoreconf && rm -r autom4te.cache".
52+[...]
53diff -pruN orig/debian/patches/series main/debian/patches/series
54--- orig/debian/patches/series 2009-09-12 10:08:25.380267231 +0200
55+++ main/debian/patches/series 2009-09-10 16:29:13.607775138 +0200
56@@ -1,3 +1,4 @@
57+autoreconf.patch
58 ignone-desktop.in.patch
59 remove-obsolete-potfile.patch
60 remove-extra-licenses.patch

« Back to merge proposal