Code review comment for lp:~bdfhjk/clicompanion/setupscript

Jonathan Marsden (jmarsden) wrote :

On 04/06/2012 03:59 AM, Marek Bardoński wrote:

> Marek Bardoński has proposed merging
> lp:~bdfhjk/clicompanion/setupscript into lp:clicompanion.

>> file '.bzrignore' (properties changed: -x to +x)
>> file '.clicompanion' (properties changed: -x to +x)
>> file 'MANIFEST' (properties changed: -x to +x)
>> file 'clicompanion.1' (properties changed: -x to +x)
>> file 'clicompanionlib/__init__.py' (properties changed: -x to +x)
>> file 'clicompanionlib/config.py' (properties changed: -x to +x)
>> file 'clicompanionlib/helpers.py' (properties changed: -x to +x)
>> file 'clicompanionlib/menus_buttons.py' (properties changed: -x to +x)
>> file 'clicompanionlib/plugins.py' (properties changed: -x to +x)
>> file 'clicompanionlib/preferences.py' (properties changed: -x to +x)
>> file 'clicompanionlib/tabs.py' (properties changed: -x to +x)
>> file 'clicompanionlib/utils.py' (properties changed: -x to +x)
>> file 'clicompanionlib/view.py' (properties changed: -x to +x)
>> file 'data/clicompanion.16.png' (properties changed: -x to +x)
>> file 'data/clicompanion.64.png' (properties changed: -x to +x)
>> file 'data/clicompanion.desktop' (properties changed: -x to +x)

What is going on here? Why are we now marking so many files as
executable? You can't really execute a .png file...?! Was this change
intended? If not, please avoid the unwanted properties changes before
merging.

Thanks,

Jonathan

« Back to merge proposal