Merge lp:~bdfhjk/clicompanion/copyright-fix into lp:~clicompanion-devs/clicompanion/debian

Proposed by Marek Bardoński
Status: Merged
Approved by: David Caro
Approved revision: 21
Merged at revision: 20
Proposed branch: lp:~bdfhjk/clicompanion/copyright-fix
Merge into: lp:~clicompanion-devs/clicompanion/debian
Diff against target: 60 lines (+18/-7)
2 files modified
control (+1/-1)
copyright (+17/-6)
To merge this branch: bzr merge lp:~bdfhjk/clicompanion/copyright-fix
Reviewer Review Type Date Requested Status
David Caro Approve
Jonathan Marsden Needs Fixing
Review via email: mp+87047@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Marsden (jmarsden) wrote :

Something seems odd here:

+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see .

See what? :)

Jonathan

review: Needs Fixing
21. By Marek Bardoński

copyright updated (new upstream authors) and small fix for licence statement

Revision history for this message
Marek Bardoński (bdfhjk) wrote :

Thanks Jonathan for pointing this. I modified text to be more clear. Also updated was list of authors to be compatible with headers.

Revision history for this message
David Caro (dcaro) wrote :

We could also remove most from the dependencies (is not used anymore).

Revision history for this message
David Caro (dcaro) wrote :

Everything else seems fine to me, opening another bug for the most dependency.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'control'
--- control 2011-11-10 11:21:56 +0000
+++ control 2012-01-13 21:42:23 +0000
@@ -14,7 +14,7 @@
1414
15Package: clicompanion15Package: clicompanion
16Architecture: all16Architecture: all
17Depends: ${misc:Depends}, ${python:Depends}, most, python-vte, python-gtk217Depends: ${misc:Depends}, ${python:Depends}, most, python-vte, python-gtk2, sudo
18Description: run terminal commands from a GUI storing commands for later use18Description: run terminal commands from a GUI storing commands for later use
19 CLI Companion is an application that is used as a complement to the Terminal.19 CLI Companion is an application that is used as a complement to the Terminal.
20 .20 .
2121
=== modified file 'copyright'
--- copyright 2011-11-04 15:10:04 +0000
+++ copyright 2012-01-13 21:42:23 +0000
@@ -3,7 +3,7 @@
3Source: https://code.launchpad.net/~clicompanion-devs/clicompanion/trunk3Source: https://code.launchpad.net/~clicompanion-devs/clicompanion/trunk
44
5Files: *5Files: *
6Copyright: Copyright (C) 2010 Duane Hinnen, Kenny Meyer6Copyright: Copyright (C) 2010 Duane Hinnen, Kenny Meyer, David Caro, Marek Bardoński
7License: GPL-3+7License: GPL-3+
8 This program is free software: you can redistribute it and/or modify8 This program is free software: you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by9 it under the terms of the GNU General Public License as published by
@@ -15,9 +15,6 @@
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details.16 GNU General Public License for more details.
17 .17 .
18 You should have received a copy of the GNU General Public License
19 along with this program. If not, see .
20 .
21 On Debian systems, the full text of the GNU General Public18 On Debian systems, the full text of the GNU General Public
22 License version 3 can be found in the file19 License version 3 can be found in the file
23 '/usr/share/common-licenses/GPL-3'20 '/usr/share/common-licenses/GPL-3'
@@ -35,8 +32,22 @@
35 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the32 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
36 GNU General Public License for more details.33 GNU General Public License for more details.
37 .34 .
38 You should have received a copy of the GNU General Public License35 On Debian systems, the full text of the GNU General Public
39 along with this program. If not, see .36 License version 3 can be found in the file
37 '/usr/share/common-licenses/GPL-3'
38
39Files: images/*
40Copyright: Copyright (C) 2011 Sean Kelly
41License: GPL-3+
42 This program is free software: you can redistribute it and/or modify
43 it under the terms of the GNU General Public License as published by
44 the Free Software Foundation, either version 3 of the License, or
45 (at your option) any later version.
46 .
47 This program is distributed in the hope that it will be useful,
48 but WITHOUT ANY WARRANTY; without even the implied warranty of
49 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
50 GNU General Public License for more details.
40 .51 .
41 On Debian systems, the full text of the GNU General Public52 On Debian systems, the full text of the GNU General Public
42 License version 3 can be found in the file53 License version 3 can be found in the file

Subscribers

People subscribed via source and target branches