Code review comment for lp:~bcwaldon/nova/lp713144

Revision history for this message
Matt Dietz (cerberus) wrote :

Hi Brian!

The passes on lines 28 and 36 seem superfluous.

The list comprehension on 32-33 is pretty odd and a bit unreadable IMO. Perhaps even ruby-ish ;-) Additionally, you're effectively building a list of stuff that you're immediately throwing away, in addition to the list you're actually appending to. I'd like to see this refactored to something a bit cleaner.

Also datetime should be alphabetically listed before json in test_servers.py

review: Needs Fixing

« Back to merge proposal