Code review comment for lp:~bcsaller/pyjuju/sane_output_test_option

Revision history for this message
Benjamin Saller (bcsaller) wrote :

Please take a look.

https://codereview.appspot.com/6216053/diff/1/juju/hooks/cli.py
File juju/hooks/cli.py (right):

https://codereview.appspot.com/6216053/diff/1/juju/hooks/cli.py#newcode228
juju/hooks/cli.py:228: # yaml dump container types
On 2012/05/17 02:42:44, niemeyer wrote:
> What was your thinking here? I believe it should dump yaml in all
cases. i.e.
> "true", not "True".

You're correct that non-string types should appear here.

https://codereview.appspot.com/6216053/

« Back to merge proposal