Code review comment for lp:~bcsaller/pyjuju/lxc-omega

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

post commit review..

[0]
        if not master_template.is_constructed():
            yield self.master_template.create()
            log.debug("Created master container %s" % container_template_name)

That's a bug, there is no instance attribute self.master_template

[1] Lots of over 80 lines, diff to fix (also includes fix for 0)
http://paste.ubuntu.com/699361/

[2] test_containers should be subsumed along with the implmeentation into the
 lib/lxc package.

« Back to merge proposal