[1] I'd prefer the master template to be namespace'd to the environment, it makes its cleanup automatic (if it gets broken), and allows divergence in series across environments.
[2] There's a few minor style violations, mostly of the over 80 col variety, ie.
+ if self._public_key:
+ args.insert(1, "JUJU_PUBLIC_KEY=%s" % pipes.quote(self._public_key))
Looks good to me, some minors
[0] Please use self.juju_home as the base for the lock
762 + lockfile = FilesystemLock( os.path. join( template_ name))
763 + "/tmp/", "%s.lock" % container_
[1] I'd prefer the master template to be namespace'd to the environment, it makes its cleanup automatic (if it gets broken), and allows divergence in series across environments.
[2] There's a few minor style violations, mostly of the over 80 col variety, ie.
+ if self._public_key: KEY=%s" % pipes.quote( self._public_ key))
+ args.insert(1, "JUJU_PUBLIC_