pyjuju

Code review comment for lp:~bcsaller/pyjuju/lxc-killpid

  1. lxc-killpid
  2. Merge into trunk
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

https://codereview.appspot.com/6460118/diff/1/juju/lib/service.py
File juju/lib/service.py (right):

https://codereview.appspot.com/6460118/diff/1/juju/lib/service.py#newcode112
juju/lib/service.py:112: yield self._call("kill", self.get_pid())
having seen wrap-around pid behavior where this refers to an entirely
different process, this makes me wary.

https://codereview.appspot.com/6460118/diff/1/juju/lib/service.py#newcode118
juju/lib/service.py:118:
what happens to the stop/destroy case if the pidfile doesn't exist?

https://codereview.appspot.com/6460118/

Reply

« Back to merge proposal