Code review comment for lp:~bcsaller/juju-gui/topology-panzoom

Revision history for this message
Benjamin Saller (bcsaller) wrote :

Reviewers: mp+140671_code.launchpad.net,

Message:
Please take a look.

Description:
Panzoom Module

This branch breaks out the first module
from Mega into a more module unit. While this
module is small a number of changes occur to make
this happen. The framework underwent some improvemnts,
changes around interaction with App and view replacement
occured, event bindings had to be updated. A pattern for
cross module event firing was established.

In future modules, the topo/component fires the events and
modules are bubble targets.

https://code.launchpad.net/~bcsaller/juju-gui/topology-panzoom/+merge/140671

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6971045/

Affected files:
   [revision details]
   app/app.js
   app/assets/javascripts/d3-components.js
   app/templates/overview.handlebars
   app/views/environment.js
   app/views/topology/mega.js
   app/views/topology/panzoom.js
   app/views/topology/topology.js
   test/test_d3_components.js
   test/test_environment_view.js
   test/test_topology.js
   undocumented

« Back to merge proposal