Code review comment for lp:~bcsaller/juju-gui/service-click-actions-begone

Revision history for this message
Benjamin Saller (bcsaller) wrote :

On 2013/02/01 16:41:54, matthew.scott wrote:
> Two things, one comment in code.

> Also encountered: attempting to destroy a service leads to the
following in
> juju: http://pastebin.ubuntu.com/1597784/ The WS then disconnects and
> reconnects, and the dialog is left hanging out in the GUI. Confirmed
that this
> works in my branch, which I've yet to merge with anything.

https://codereview.appspot.com/7228070/diff/9001/app/views/topology/service.js
> File app/views/topology/service.js (right):

https://codereview.appspot.com/7228070/diff/9001/app/views/topology/service.js#newcode342
> app/views/topology/service.js:342: box.inDrag = 2;
> Line above is still using service_click_actions, throwing an exception
when
> dragging a service (if it's not caught, relation lines don't move
until
> annotations come back and things are redrawn).

I wasn't able to reproduce the destroy service issue. I'll resubmit this
with the other fix from the poor merge.

https://codereview.appspot.com/7228070/

« Back to merge proposal