Merge lp:~bcsaller/juju-gui/nostatusforoldsubordinates into lp:juju-gui/experimental
Proposed by
Benjamin Saller
Status: | Merged |
---|---|
Merged at revision: | 837 |
Proposed branch: | lp:~bcsaller/juju-gui/nostatusforoldsubordinates |
Merge into: | lp:juju-gui/experimental |
Diff against target: |
59 lines (+14/-10) 2 files modified
app/views/topology/service.js (+14/-9) app/views/utils.js (+0/-1) |
To merge this branch: | bzr merge lp:~bcsaller/juju-gui/nostatusforoldsubordinates |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+174842@code.launchpad.net |
Description of the change
Subordinates don't get status bars
Subordinates could render status in the future, but for now we omit
this as the UI relating to mapping sub units to principal service units
is unclear.
To post a comment you must log in.
Reviewers: mp+174842_ code.launchpad. net,
Message:
Please take a look.
Description:
Subordinates don't get status bars
Subordinates could render status in the future, but for now we omit
this as the UI relating to mapping sub units to principal service units
is unclear.
https:/ /code.launchpad .net/~bcsaller/ juju-gui/ nostatusforolds ubordinates/ +merge/ 174842
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/11295043/
Affected files: topology/ service. js
A [revision details]
M app/views/
M app/views/utils.js
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: app/views/utils.js utils.js'
=== modified file 'app/views/
--- app/views/utils.js 2013-07-11 14:56:15 +0000
+++ app/views/utils.js 2013-07-15 19:38:30 +0000
@@ -772,7 +772,6 @@
return errors;
};
-
/**
* Utility object that encapsulates Y.Models and keeps their position
* state within an SVG canvas.
Index: app/views/ topology/ service. js topology/ service. js' topology/ service. js 2013-07-15 15:52:04 +0000 topology/ service. js 2013-07-15 19:38:30 +0000
node.append( 'image' )
.classed( 'service- icon', true)
width: 96,
height: 96,
transform: 'translate(47, 50)'
.classed( 'statusbar' , true);
=== modified file 'app/views/
--- app/views/
+++ app/views/
@@ -883,7 +883,9 @@
.attr({
- 'xlink:href': function(d) {return d.icon;},
+ 'xlink:href': function(d) {
+ return d.icon;
+ },
@@ -899,13 +901,16 @@
- d3.select(
- resize: false,
- width: 160,
- target: this,
- fontSize: 8,
- labels: false
- }).render());
+ if (!d.subordinate) {
+ d3.select(
+ new views.StatusBar({
+ resize: false,
+ width: 160,
+ target: this,
+ fontSize: 8,
+ labels: false
+ }).render());
+ }
});
// Manually attach the touchstart event (see method for details)
@@ -1149,7 +1154,7 @@
var status_graph = d3.select(
var status_bar = status_
- if (status_bar) {
+ if (status_bar && !d.subordinate) {
}
});