https://codereview.appspot.com/7327045/diff/26001/app/app.js#newcode351
app/app.js:351: _navigate: function(url, options) {
I would like to see this in a YUI extension eventually. Extensions
encourage modularity, make it a lot easier to document and, for external
developers, to see that you're overwriting core methods. This would also
follow the 'YUI way' for this type of modification. - We can do this in
a separate branch later -
Looks good! I just wanted to add a comment for a future enhancement.
https:/ /codereview. appspot. com/7327045/ diff/26001/ app/app. js
File app/app.js (right):
https:/ /codereview. appspot. com/7327045/ diff/26001/ app/app. js#newcode351
app/app.js:351: _navigate: function(url, options) {
I would like to see this in a YUI extension eventually. Extensions
encourage modularity, make it a lot easier to document and, for external
developers, to see that you're overwriting core methods. This would also
follow the 'YUI way' for this type of modification. - We can do this in
a separate branch later -
https:/ /codereview. appspot. com/7327045/