Code review comment for lp:~bcsaller/juju-gui/namespace-routing

Revision history for this message
Madison Scott-Clary (makyo) wrote :

Just a quick FYI.

https://codereview.appspot.com/7327045/diff/16001/app/assets/javascripts/routing.js
File app/assets/javascripts/routing.js (right):

https://codereview.appspot.com/7327045/diff/16001/app/assets/javascripts/routing.js#newcode90
app/assets/javascripts/routing.js:90: console.log('URL namespace without
path');
On 2013/02/18 17:12:47, jeff.pihach wrote:
> If you're creating logs for debugging it's best to use Y.log() because
it can
> then be filtered in or out during debugging instead of always logging
to the
> console.

For what it's worth, console is current filtered by deployment path
(i.e.: turned off for production, etc). The reasons for using
console.log() also include the fact that one can log multiple objects,
group, and nest logs. This is part of our coding standard decided on
previously.

https://codereview.appspot.com/7327045/

« Back to merge proposal