Code review comment for lp:~bcsaller/juju-gui/hotkey-ext

Revision history for this message
Gary Poster (gary) wrote :

LGTM. Maybe we should remove the feature flag simulator support? Oh,
and I think we should always instantiate the simulator in sandbox mode,
but only start it if simulateEvents is true in the config?

Thanks!

https://codereview.appspot.com/9694043/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9694043/diff/1/app/app.js#newcode173
app/app.js:173: '/': {
+1
...though on reflection it reminds me that we will need to change this
to work with the charm browser when it lands. Can cross the bridge when
we come to it.

https://codereview.appspot.com/9694043/diff/1/app/app.js#newcode207
app/app.js:207: '+': {
cool :-)

https://codereview.appspot.com/9694043/

« Back to merge proposal