On 2012/11/28 12:33:03, teknico wrote:
> Thanks for these docs, they're much useful.
> I made quite a few small adjustments to the text flow and markup, so
instead of
> wasting your time and mine by making lots of small comments inline, I
just
> created a new branch and made all changes there. I did not reflow
paragraphs
> even when lines got too long, to avoid obscuring the changes in the
diff.
> Note that some additions and deletions of blank lines are needed to
make the
> document compile to HTML correctly.
> I also added the document to the index.rst file, so that it appears in
the
> generated output.
> I'm sorry for the extensive rework: I do believe it significantly
improves
> overall readability, however.
On 2012/11/28 12:33:03, teknico wrote:
> Thanks for these docs, they're much useful.
> I made quite a few small adjustments to the text flow and markup, so
instead of
> wasting your time and mine by making lots of small comments inline, I
just
> created a new branch and made all changes there. I did not reflow
paragraphs
> even when lines got too long, to avoid obscuring the changes in the
diff.
> Note that some additions and deletions of blank lines are needed to
make the
> document compile to HTML correctly.
> I also added the document to the index.rst file, so that it appears in
the
> generated output.
> I'm sorry for the extensive rework: I do believe it significantly
improves
> overall readability, however.
> Please find the changes at lp:~teknico/juju-gui/framework-docs .
Thank you! I merged your changes to this branch and will re-propose if
there is another reviewer.
https:/ /codereview. appspot. com/6858085/