Code review comment for lp:~bcsaller/juju-gui/exportXY

Revision history for this message
Benjamin Saller (bcsaller) wrote :

I believe you when you say that it didn't happen in QA at the midway
point. My feeling was that it was working better as well before but
trying to get it passing the existing tests forced some changes and
while I thought I got it back into shape it seems this must be resolved.

One difference I know is that I don't publish annotations for packed
elements as this was interfering with imports. They'd get build and the
delta comes back, they get placed, and the annotation set and then the
imports set annotations call fires and another delta comes in, racing
with the cli placement. That change and the case where I decide when to
pan (which should only happen after packing more than one new service)
both need looking at. I'll try to resolve these. If that doesn't work we
can back up the patch a few revisions and try to merge in test changes.

I'll look into this now.

https://codereview.appspot.com/14695043/

« Back to merge proposal