Thanks for the reviews
https://codereview.appspot.com/11227043/diff/1/app/models/models.js File app/models/models.js (right):
https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode889 app/models/models.js:889: // Process the serivce_options removing any values On 2013/07/12 21:32:11, gary.poster wrote: > trivial: service_options
Done.
https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode900 app/models/models.js:900: // Using package name here so the default series On 2013/07/12 21:32:11, gary.poster wrote: > This comment is no longer correct. Delete?
Ha, the "this is likely..." part was still valid, removed though as its happened.
https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode919 app/models/models.js:919: // than relative which would make more sense in an export. On 2013/07/12 21:15:00, rharding wrote: > should this be an XXX vs a note then if it doesn't make much sense as is?
XXX'd :)
https://codereview.appspot.com/11227043/
« Back to merge proposal
Thanks for the reviews
https:/ /codereview. appspot. com/11227043/ diff/1/ app/models/ models. js models. js (right):
File app/models/
https:/ /codereview. appspot. com/11227043/ diff/1/ app/models/ models. js#newcode889 models. js:889: // Process the serivce_options removing any
app/models/
values
On 2013/07/12 21:32:11, gary.poster wrote:
> trivial: service_options
Done.
https:/ /codereview. appspot. com/11227043/ diff/1/ app/models/ models. js#newcode900 models. js:900: // Using package name here so the default
app/models/
series
On 2013/07/12 21:32:11, gary.poster wrote:
> This comment is no longer correct. Delete?
Ha, the "this is likely..." part was still valid, removed though as its
happened.
https:/ /codereview. appspot. com/11227043/ diff/1/ app/models/ models. js#newcode919 models. js:919: // than relative which would make more sense
app/models/
in an export.
On 2013/07/12 21:15:00, rharding wrote:
> should this be an XXX vs a note then if it doesn't make much sense as
is?
XXX'd :)
https:/ /codereview. appspot. com/11227043/