LGTM with trivials, thank you!
https://codereview.appspot.com/11227043/diff/1/app/models/models.js File app/models/models.js (right):
https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode889 app/models/models.js:889: // Process the serivce_options removing any values trivial: service_options
https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode900 app/models/models.js:900: // Using package name here so the default series This comment is no longer correct. Delete?
https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode919 app/models/models.js:919: // than relative which would make more sense in an export. Good point. File a bug? Low priority until someone asks for it.
https://codereview.appspot.com/11227043/
« Back to merge proposal
LGTM with trivials, thank you!
https:/ /codereview. appspot. com/11227043/ diff/1/ app/models/ models. js models. js (right):
File app/models/
https:/ /codereview. appspot. com/11227043/ diff/1/ app/models/ models. js#newcode889 models. js:889: // Process the serivce_options removing any
app/models/
values
trivial: service_options
https:/ /codereview. appspot. com/11227043/ diff/1/ app/models/ models. js#newcode900 models. js:900: // Using package name here so the default
app/models/
series
This comment is no longer correct. Delete?
https:/ /codereview. appspot. com/11227043/ diff/1/ app/models/ models. js#newcode919 models. js:919: // than relative which would make more sense
app/models/
in an export.
Good point. File a bug? Low priority until someone asks for it.
https:/ /codereview. appspot. com/11227043/