Code review comment for lp:~bcsaller/charm-tools/composer

I'm eager to merge this but can't get the tests to run. I always run `make check` on charm-tools since that includes the integration tests as well. According to the Makefile that should still work, but I get:

tvansteenburgh@trusty-vm:/tmp/charm-tools> make clean
find . -name '*.py[co]' -delete
find . -type f -name '*~' -delete
find . -name '*.bak' -delete
rm -rf bin include lib local man dependencies
tvansteenburgh@trusty-vm:/tmp/charm-tools> make check
bzr checkout lp:~juju-jitsu/charm-tools/dependencies
tox --develop
py27 create: /tmp/charm-tools/.tox/py27
py27 installdeps: -r/tmp/charm-tools/requirements.txt
ERROR: invocation failed, logfile: /tmp/charm-tools/.tox/py27/log/py27-1.log
ERROR: actionid=py27
msg=getenv
cmdargs=[local('/tmp/charm-tools/.tox/py27/bin/pip'), 'install', '--no-index', '-f', 'dependencies/python', '-r/tmp/charm-tools/requirements.txt']
env={'BYOBU_TTY': '/dev/pts/1', 'UPSTART_EVENTS': 'started starting', 'SHELL': '/bin/bash', 'XDG_DATA_DIRS': '/usr/share/ubuntu:/usr/share/gnome:/usr/local/share/:/usr/share/', 'MANDATORY_PATH': '/usr/share/gconf/ubuntu.mandatory.path', 'CLUTTER_IM_MODULE': 'xim', 'BYOBU_RUN_DIR': '/dev/shm/byobu-tvansteenburgh-KRSOmrmO', 'UPSTART_INSTANCE': '', 'JOB': 'gnome-session', 'TEXTDOMAIN': 'im-config', 'XMODIFIERS': '@im=ibus', 'MFLAGS': '', 'SELINUX_INIT': 'YES', 'BYOBU_SED': 'sed', 'BYOBU_LIGHT': '#EEEEEE', 'DESKTOP_SESSION': 'ubuntu', 'BYOBU_DATE': '%Y-%m-%d ', 'XDG_SESSION_ID': 'c1', 'DBUS_SESSION_BUS_ADDRESS': 'unix:abstract=/tmp/dbus-m7XWOMt928', 'DEFAULTS_PATH': '/usr/share/gconf/ubuntu.default.path', 'LESS_TERMCAP_ue': '\x1b[0m', 'GTK_MODULES': 'overlay-scrollbar:unity-gtk-module', 'INSTANCE': 'Unity', 'LESS_TERMCAP_us': '\x1b[04;38;5;139m', 'LS_COLORS': 'rs=0:di=38;5;5:ln=4;5;37:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:su=37;41:sg=30;43:ca=30;41:tw=3;28:ow=34;42:st=37;44:ex=38;5;202:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.dz=01;31:*.gz=01;31:*.lz=01;31:*.xz=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.jpg=01;35:*.jpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.axv=01;35:*.anx=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.axa=00;36:*.oga=00;36:*.spx=00;36:*.xspf=00;36:', 'GOPATH': '/home/tvansteenburgh/src/go', 'GNOME_DESKTOP_SESSION_ID': 'this-is-deprecated', 'BYOBU_WINDOW_NAME': '-', 'LESSOPEN': '| /usr/bin/lesspipe %s', 'USER': 'tvansteenburgh', 'XDG_VTNR': '7', 'XAUTHORITY': '/home/tvansteenburgh/.Xauthority', 'LANGUAGE': 'en_US', 'SHLVL': '3', 'QT_QPA_PLATFORMTHEME': 'appmenu-qt5', 'COMPIZ_CONFIG_PROFILE': 'ubuntu', 'WINDOWID': '71303180', 'EDITOR': 'vim', 'GPG_AGENT_INFO': '/run/user/1000/keyring-uBeTRE/gpg:0:1', 'BYOBU_DARK': '#333333', 'TMUX': '/tmp/tmux-1000/default,5734,1', 'GDMSESSION': 'ubuntu', 'UPSTART_JOB': 'unity-settings-daemon', 'BYOBU_PREFIX': '/usr', 'XDG_SEAT_PATH': '/org/freedesktop/DisplayManager/Seat0', '_': '/usr/bin/make', 'GTK_IM_MODULE': 'ibus', 'XDG_CONFIG_DIRS': '/etc/xdg/xdg-ubuntu:/usr/share/upstart/xdg:/etc/xdg', 'BYOBU_TIME': '%H:%M:%S', 'BYOBU_DISTRO': 'Ubuntu', 'BYOBU_READLINK': 'readlink', 'TEXTDOMAINDIR': '/usr/share/locale/', 'COLORTERM': 'gnome-terminal', 'XDG_GREETER_DATA_DIR': '/var/lib/lightdm-data/tvansteenburgh', 'QT4_IM_MODULE': 'xim', 'HOME': '/tmp/charm-tools/.tox/py27/tmp/pseudo-home', 'DISPLAY': ':0', 'LANG': 'en_US.UTF-8', 'BYOBU_BACKEND': 'tmux', 'GOROOT': '/usr/lib/go', 'BYOBU_ULIMIT': 'ulimit', 'GREP_COLORS': 'ms=01;38;5;202:mc=01;31:sl=:cx=:fn=01;38;5;132:ln=32:bn=32:se=00;38;5;242', 'COMP_WORDBREAKS': ' \t\n"\'><;|&(:', 'VTE_VERSION': '3409', 'XDG_CURRENT_DESKTOP': 'Unity', 'BYOBU_PAGER': 'sensible-pager', 'LESSCLOSE': '/usr/bin/lesspipe %s %s', 'GNOME_KEYRING_PID': '2654', 'MAKELEVEL': '1', 'BYOBU_CHARMAP': 'x', 'BYOBU_CONFIG_DIR': '/home/tvansteenburgh/.byobu', 'TMUX_PANE': '%5', 'PYTHONIOENCODING': 'utf_8', 'QT_IM_MODULE': 'ibus', 'LOGNAME': 'tvansteenburgh', 'XDG_SEAT': 'seat0', 'GNOME_KEYRING_CONTROL': '/run/user/1000/keyring-uBeTRE', 'PATH': '/tmp/charm-tools/.tox/py27/bin:/home/tvansteenburgh/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/home/tvansteenburgh/bin:/home/tvansteenburgh/.juju-plugins:/usr/local/go/bin:/home/tvansteenburgh/bin:/home/tvansteenburgh/.juju-plugins:/usr/local/go/bin', 'MAKEFLAGS': '', 'XDG_RUNTIME_DIR': '/run/user/1000', 'TERM': 'screen', 'XDG_SESSION_PATH': '/org/freedesktop/DisplayManager/Session0', 'LESS_TERMCAP_me': '\x1b[0m', 'LESS_TERMCAP_md': '\x1b[01;38;5;180m', 'LESS_TERMCAP_mb': '\x1b[01;31m', 'SESSIONTYPE': 'gnome-session', 'IM_CONFIG_PHASE': '1', 'SSH_AUTH_SOCK': '/home/tvansteenburgh/.byobu/.ssh-agent', 'BYOBU_HIGHLIGHT': '#DD4814', 'BYOBU_ACCENT': '#75507B', 'UPSTART_SESSION': 'unix:abstract=/com/ubuntu/upstart-session/1000/1829', 'OLDPWD': '/tmp', 'GDM_LANG': 'en_US', 'LESS_TERMCAP_se': '\x1b[0m', 'PWD': '/tmp/charm-tools', 'BYOBU_PYTHON': 'python3', 'LESS_TERMCAP_so': '\x1b[03;38;5;202m'}
Ignoring indexes: https://pypi.python.org/simple
Collecting PyYAML==3.11 (from -r /tmp/charm-tools/requirements.txt (line 1))
  The repository located at None is not a trusted or secure host and is being ignored. If this repository is available via HTTPS it is recommended to use HTTPS instead, otherwise you may silence this warning and allow it anyways with '--trusted-host None'.
  Could not find a version that satisfies the requirement PyYAML==3.11 (from -r /tmp/charm-tools/requirements.txt (line 1)) (from versions: )
No matching distribution found for PyYAML==3.11 (from -r /tmp/charm-tools/requirements.txt (line 1))

ERROR: could not install deps [-r/tmp/charm-tools/requirements.txt]
______________________________________________________________________________________________________________________________________ summary ______________________________________________________________________________________________________________________________________
ERROR: py27: could not install deps [-r/tmp/charm-tools/requirements.txt]
make: *** [develop] Error 1
2 tvansteenburgh@trusty-vm:/tmp/charm-tools> ll dependencies/python/
total 14036
drwxrwxr-x 2 tvansteenburgh tvansteenburgh 4096 Aug 27 16:31 ./
drwxrwxr-x 4 tvansteenburgh tvansteenburgh 4096 Aug 27 16:31 ../
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 11301124 Aug 27 16:31 bzr-2.6.0.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 6895 Aug 27 16:31 charmworldlib-0.2.4-1.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 4232 Aug 27 16:31 charmworldlib-0.3.0.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 4665 Aug 27 16:31 charmworldlib-0.4.2.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 284735 Aug 27 16:31 coverage-3.7.1.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 39626 Aug 27 16:31 flake8-1.6.2.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 116500 Aug 27 16:31 httplib2-0.7.7.zip
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 29549 Aug 27 16:31 jujubundlelib-0.1.9.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 270837 Aug 27 16:31 launchpadlib-1.10.2.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 21190 Aug 27 16:31 lazr.authentication-0.1.2.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 55831 Aug 27 16:31 lazr.restfulclient-0.13.1.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 18601 Aug 27 16:31 lazr.uri-1.0.3.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 818644 Aug 27 16:31 mock-1.0.1.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 400377 Aug 27 16:31 nose-1.2.1.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 9533 Aug 27 16:31 oauth-1.0.1.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 241524 Aug 27 16:31 PyYAML-3.10.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 248685 Aug 27 16:31 PyYAML-3.11.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 337229 Aug 27 16:31 requests-1.1.0.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 49957 Aug 27 16:31 simplejson-2.2.1.tar.gz
-rw-rw-r-- 1 tvansteenburgh tvansteenburgh 59482 Aug 27 16:31 wadllib-1.3.1.tar.gz

Note in this instance I had not yet run `pip wheel -w dependencies/python -r requirements.txt`, but even after doing so I get the same result.