Code review comment for lp:~bcim/account-invoicing/7.0-account_invoice_line_default_account

Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

Just on the version numbering.

It is needed the way it is. As it is the ONLY way of knowing that this module was adapted to and tested on the specified version.

The core action of automatically adding a version number is a completely futile exercise, as it will be 7.0 on for all modules on an 7.0 installation and all 6.1 on a 6.1 installation etc.

For the rest I think Pedro made good suggestions.

« Back to merge proposal