Code review comment for lp:~bben-pub/igotu2gpx/igotu2gpx

Revision history for this message
Matija Nalis (mnalis) wrote :

> > "2016 FIX" part doesn't work for me on GT-200 (Firmware version: 2.11,
> Model:
> > GT-200) - it claims to have "Number of points: 7536640" on empty device
> which
> > is way too much (and so download takes hours). Without this patch it
> correctly
> > says "Number of points: 0"
>
> I believe the issue comes from the previous update on which I based my changes
> (which simply modify the dates). I used a fix to support GT600 devices as it's
> the one I have, but it may break the GT200 compatibility. Did you try to use
> that GT600 branch to check if it's true?

the issue seems to be with
http://bazaar.launchpad.net/~bben-pub/igotu2gpx/igotu2gpx/revision/213
at file "src/lib/igotu/commands.cpp" where there is added command
"count += result.data()[0]<<16;" being unconditionally done. It probably should be executed only if GT-600 (or GT-200e?) is detected, a not for everybody else (like plain GT-200).

« Back to merge proposal