Merge lp:~bbaqar/charms/trusty/plumgrid-gateway/ext-interface-static into lp:~junaidali/charms/trusty/plumgrid-gateway/trunk

Proposed by Junaid Ali
Status: Merged
Merged at revision: 32
Proposed branch: lp:~bbaqar/charms/trusty/plumgrid-gateway/ext-interface-static
Merge into: lp:~junaidali/charms/trusty/plumgrid-gateway/trunk
Diff against target: 47 lines (+10/-16) (has conflicts)
2 files modified
hooks/pg_gw_utils.py (+6/-16)
templates/kilo/ifcs.conf (+4/-0)
Text conflict in templates/kilo/ifcs.conf
To merge this branch: bzr merge lp:~bbaqar/charms/trusty/plumgrid-gateway/ext-interface-static
Reviewer Review Type Date Requested Status
Junaid Ali Pending
Review via email: mp+296969@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/pg_gw_utils.py'
--- hooks/pg_gw_utils.py 2016-05-23 10:31:14 +0000
+++ hooks/pg_gw_utils.py 2016-06-09 17:28:49 +0000
@@ -285,22 +285,12 @@
285 Gateway node can have multiple interfaces. This function parses json285 Gateway node can have multiple interfaces. This function parses json
286 provided in config to get all gateway interfaces for this node.286 provided in config to get all gateway interfaces for this node.
287 '''287 '''
288 node_interfaces = []288 interface = config('external-interfaces')
289 try:289 if not interface_exists(interface):
290 all_interfaces = json.loads(config('external-interfaces'))290 log('Provided gateway interface %s does not exist'
291 except ValueError:291 % interface)
292 raise ValueError("Invalid json provided for gateway interfaces")292 raise ValueError('Provided gateway interface does not exist')
293 hostname = get_unit_hostname()293 return interface
294 if hostname in all_interfaces:
295 node_interfaces = all_interfaces[hostname].split(',')
296 elif 'DEFAULT' in all_interfaces:
297 node_interfaces = all_interfaces['DEFAULT'].split(',')
298 for interface in node_interfaces:
299 if not interface_exists(interface):
300 log('Provided gateway interface %s does not exist'
301 % interface)
302 raise ValueError('Provided gateway interface does not exist')
303 return node_interfaces
304294
305295
306def ensure_mtu():296def ensure_mtu():
307297
=== modified file 'templates/kilo/ifcs.conf'
--- templates/kilo/ifcs.conf 2016-05-21 11:54:18 +0000
+++ templates/kilo/ifcs.conf 2016-06-09 17:28:49 +0000
@@ -1,7 +1,11 @@
1{{ fabric_interface }} = fabric_core host1{{ fabric_interface }} = fabric_core host
2<<<<<<< TREE
2{% if ext_interfaces -%}3{% if ext_interfaces -%}
3{% for dev in ext_interfaces -%}4{% for dev in ext_interfaces -%}
4{{ dev }} = access_phys5{{ dev }} = access_phys
5{% endfor -%}6{% endfor -%}
6{% endif -%}7{% endif -%}
8=======
9{{ ext_interfaces }} = access_phys
10>>>>>>> MERGE-SOURCE
711

Subscribers

People subscribed via source and target branches

to all changes: