Merge ~barryprice/turnip:master into turnip:master

Proposed by Barry Price
Status: Merged
Approved by: Colin Watson
Approved revision: 0afd76d8de5e24befeb2dade992d13d55bf9146f
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~barryprice/turnip:master
Merge into: turnip:master
Diff against target: 12 lines (+1/-1)
1 file modified
charm/layer/turnip-base/lib/charms/turnip/base.py (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+399759@code.launchpad.net

Commit message

Reformat our E2E check hint to avoid using parentheses, which Nagios considers illegal

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/charm/layer/turnip-base/lib/charms/turnip/base.py b/charm/layer/turnip-base/lib/charms/turnip/base.py
index 4cd1f55..39e0fcc 100644
--- a/charm/layer/turnip-base/lib/charms/turnip/base.py
+++ b/charm/layer/turnip-base/lib/charms/turnip/base.py
@@ -320,7 +320,7 @@ def add_nagios_e2e_checks(nagios):
320 nagios.add_check(320 nagios.add_check(
321 [os.path.join(nrpe_dir(), 'check_git_refs'), url],321 [os.path.join(nrpe_dir(), 'check_git_refs'), url],
322 name='check_turnip_git_refs_{}'.format(i),322 name='check_turnip_git_refs_{}'.format(i),
323 description='Git E2E {} (hint: check nfs-ganesha status)'.format(323 description='Git E2E {} - hint: check nfs-ganesha status'.format(
324 url),324 url),
325 context=config['nagios_context'])325 context=config['nagios_context'])
326326

Subscribers

People subscribed via source and target branches