Merge ~barryprice/spade/+git/spade:snapcraft into spade:master

Proposed by Barry Price
Status: Superseded
Proposed branch: ~barryprice/spade/+git/spade:snapcraft
Merge into: spade:master
Prerequisite: ~barryprice/spade/+git/spade:black
Diff against target: 63 lines (+12/-5)
3 files modified
Makefile (+2/-3)
setup.py (+1/-0)
snap/snapcraft.yaml (+9/-2)
Reviewer Review Type Date Requested Status
Spade Developers Pending
Review via email: mp+394571@code.launchpad.net

This proposal has been superseded by a proposal from 2020-11-27.

Commit message

Snapcraft fixes for core20

To post a comment you must log in.
c85283a... by Barry Price

Typo

6817bc5... by Barry Price

Merge branch 'master' into flake8

1734965... by Barry Price

Merge branch 'flake8' into black

fae038f... by Barry Price

Snapcraft fixes, and ignore built snap files

dd61da3... by Barry Price

Merge branch 'black' into snapcraft

Unmerged commits

dd61da3... by Barry Price

Merge branch 'black' into snapcraft

fae038f... by Barry Price

Snapcraft fixes, and ignore built snap files

1734965... by Barry Price

Merge branch 'flake8' into black

6817bc5... by Barry Price

Merge branch 'master' into flake8

c85283a... by Barry Price

Typo

a86afa5... by Barry Price

Reformatted with black

aa2d273... by Barry Price

Address all Flake8 errors bar complexity (noqa: C901)

7e34f18... by Barry Price

Modernise, switch to python3 exclusively

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/Makefile b/Makefile
index ceb744e..0efca2a 100644
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,4 @@
1version := $(shell python3 -c "from spade import __version__; print(__version__)")1tempfiles_snap := snap/.snapcraft spade_*.snap parts/ prime/ stage/
2tempfiles_snap := snap/snapcraft.yaml spade*.snap
32
4blacken:3blacken:
5 @echo "Normalising python layout with black"4 @echo "Normalising python layout with black"
@@ -14,7 +13,7 @@ clean:
14 @git clean -fXd13 @git clean -fXd
1514
16snap: snap_clean15snap: snap_clean
17 sed -e "s/{{VERSION}}/$(version)/" snapcraft.yaml.in > snap/snapcraft.yaml16 @export SNAPCRAFT_BUILD_ENVIRONMENT=multipass
18 snapcraft17 snapcraft
1918
20snap_clean:19snap_clean:
diff --git a/setup.py b/setup.py
index 7286fa2..efd69bd 100644
--- a/setup.py
+++ b/setup.py
@@ -27,6 +27,7 @@ setup(
27 author_email="chris.stratford@canonical.com",27 author_email="chris.stratford@canonical.com",
28 license='LICENSE',28 license='LICENSE',
29 packages=find_packages(exclude=['contrib', 'docs', 'tests*']),29 packages=find_packages(exclude=['contrib', 'docs', 'tests*']),
30 setup_requires=['wheel'],
30 install_requires=[31 install_requires=[
31 "python-swiftclient",32 "python-swiftclient",
32 "python-keystoneclient",33 "python-keystoneclient",
diff --git a/snapcraft.yaml.in b/snap/snapcraft.yaml
33similarity index 74%34similarity index 74%
34rename from snapcraft.yaml.in35rename from snapcraft.yaml.in
35rename to snap/snapcraft.yaml36rename to snap/snapcraft.yaml
index 9f56fb4..8c9a196 100644
--- a/snapcraft.yaml.in
+++ b/snap/snapcraft.yaml
@@ -1,5 +1,6 @@
1name: spade1name: spade
2version: 1.02version: '1.0'
3base: core20
3summary: A tool for managing buckets in the cloud4summary: A tool for managing buckets in the cloud
4description: A tool to simplify accessing objects in cloud storage5description: A tool to simplify accessing objects in cloud storage
5 buckets (Amazon S3, Azure blobstore, Google cloud storage,6 buckets (Amazon S3, Azure blobstore, Google cloud storage,
@@ -11,8 +12,14 @@ grade: stable
11apps:12apps:
12 spade:13 spade:
13 command: bin/spade14 command: bin/spade
15 environment:
16 PATH: ${SNAP}/bin:${PATH}
17 PYTHONPATH: ${SNAP}/lib/python3
14parts:18parts:
15 spade:19 spade:
16 plugin: python20 plugin: python
17 python-version: python3
18 source: .21 source: .
22 build-environment:
23 - PYTHONPATH: "$SNAPCRAFT_PART_INSTALL/usr/lib/python3/dist-packages"
24 stage-packages:
25 - python3-wheel

Subscribers

People subscribed via source and target branches

to all changes: