Merge ~barryprice/postgresql-charm/+git/postgresql-charm:master into postgresql-charm:master
Proposed by
Barry Price
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Barry Price | ||||
Approved revision: | 9288a97b426f35850d7d05cf8d5320d7f31e9abe | ||||
Merged at revision: | 8be5b9ae4eab4d43a90a4f036e3a040120929ca5 | ||||
Proposed branch: | ~barryprice/postgresql-charm/+git/postgresql-charm:master | ||||
Merge into: | postgresql-charm:master | ||||
Diff against target: |
315 lines (+235/-5) 6 files modified
config.yaml (+16/-4) reactive/postgresql/nagios.py (+50/-1) scripts/check_latest_ready_wal.py (+54/-0) scripts/find_latest_ready_wal.py (+27/-0) unit_tests/test_check_latest_ready_wal.py (+49/-0) unit_tests/test_find_latest_ready_wal.py (+39/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Approve | ||
Review via email: mp+362732@code.launchpad.net |
Commit message
Add new scripts and config options to warn the operator about any backlog in WAL-E backups - see LP:1814523
To post a comment you must log in.
Coding seems fine.
Only running the cron job on master units is arguable. On one hand, running it everywhere is wasteful. On the other, it is only a quick script and disk write every minute or two.
Some int() casts are missing, which need to be fixed because this isn't Perl.