Code review comment for ~barryprice/launchpad-mojo-specs/+git/launchpad-mojo-specs:master

Revision history for this message
Barry Price (barryprice) wrote :

> Sorry, I should have noticed this before, but this approach still isn't quite
> going to work. Charms that we're upgrading need to go in collect-charm-
> upgrades instead. collect-charms is a baseline initial deployment for CI.
>
> (Also, no need to cast a Resubmit vote when you've made changes to your own
> MP. The purpose of Resubmit is for a reviewer to say that they think your MP
> needs to be resubmitted in some completely different shape.)

Thanks, pushed again.

« Back to merge proposal