~barryprice/charm-telegraf:split_prometheus_client_config

Branch merges

Propose for merging

Merged into charm-telegraf:master at revision 681fc188e8d79ae8420393be2b00d62d76099f7b

Haw Loeung: Approve (+1) on 2021-02-18

Canonical IS Reviewers: Pending requested 2021-02-18

BootStack Reviewers: Pending requested 2021-02-18

Diff: 382 lines (+132/-73)

4 files modified

src/reactive/telegraf.py (+107/-45)
src/templates/prometheus_client.tmpl (+3/-0)
src/templates/telegraf.conf.tmpl (+0/-6)
src/tests/unit/test_telegraf.py (+22/-22)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

6296374... by Barry Price on 2021-02-18

Address review comments

3c4a87e... by Laurent Sesquès on 2021-01-27

small fix: move flag changes to the right if stanza for config.changed

f550c15... by Laurent Sesquès on 2021-01-27

Split prometheus_client output config out of the main config file. Allow a prometheus-client relation to prometheus even if prometheus_output_port is set (and use that port in the relation).

bc10de9... by Thomas Cuthbert on 2021-01-26

Workaround for LP#1910974: telegraf haproxy input broken with Juju >= 2.8.7

Reviewed-on: https://code.launchpad.net/~tcuthbert/charm-telegraf/+git/charm-telegraf/+merge/396060
Reviewed-by: Xav Paice <email address hidden>
Reviewed-by: Peter Sabaini <email address hidden>
Reviewed-by: Haw Loeung <email address hidden>

9040361... by Paul Goins on 2021-01-15

Should use data_changed() instead of is_data_changed()

Reviewed-on: https://code.launchpad.net/~vultaire/charm-telegraf/+git/charm-telegraf/+merge/396357
Reviewed-by: Alvaro Uria <email address hidden>
Reviewed-by: Edin S <email address hidden>
Reviewed-by: Haw Loeung <email address hidden>

b7b8a51... by Paul Goins on 2021-01-14

Should use data_changed() instead of is_data_changed()

This is a bug fix for https://pad.lv/1911815.

631a400... by Thomas Cuthbert on 2021-01-13

Following Haws suggestion that we pass a listener address via relationship data and use it if present, else default to private-address as HAProxy stats listens on 0.0.0.0 by default

131c3b2... by Thomas Cuthbert on 2021-01-11

Workaround for LP#1910974: telegraf haproxy input broken with Juju >= 2.8.7

1c088cc... by Benjamin Allot on 2020-11-26

Change the default collection_jitter value to "5s"

Reviewed-on: https://code.launchpad.net/~ballot/charm-telegraf/+git/telegraf-charm/+merge/394475
Reviewed-by: James Troup <email address hidden>

e0c262d... by Benjamin Allot on 2020-11-25

Change the default collection_jitter and flush_jitter value to "5s"

See
https://github.com/influxdata/telegraf/issues/3465#issuecomment-370510543
for the explanation.
We want to prevent all the telegraf plugins to pull their metrics
exactly at the same time.
This is even more important on a server hosting a lot of VMs with
telegraf deployed inside.