Telegraf Charm

Merge ~vultaire/charm-telegraf:lp1911815 into charm-telegraf:master

  1. Git
  2. lp:~vultaire/charm-telegraf
  3. lp1911815
  4. Merge into master
Proposed by Paul Goins
Status: Merged
Approved by: Alvaro Uria
Approved revision: b7b8a51ef4dd1185c1e043863b5e58699487d59a
Merged at revision: 90403618aa7366d9f1cae3cfab3f667ec3504a3f
Proposed branch: ~vultaire/charm-telegraf:lp1911815
Merge into: charm-telegraf:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/reactive/telegraf.py (+1/-1)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Approve
Haw Loeung +1 Approve
Edin S (community) Approve
Review via email: mp+396357@code.launchpad.net

Commit message

Should use data_changed() instead of is_data_changed()

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Edin S (exsdev) :
review: Approve
Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)
Revision history for this message
Alvaro Uria (aluria) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 90403618aa7366d9f1cae3cfab3f667ec3504a3f

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/reactive/telegraf.py b/src/reactive/telegraf.py
2index c0b9e0c..136c271 100644
3--- a/src/reactive/telegraf.py
4+++ b/src/reactive/telegraf.py
5@@ -1434,7 +1434,7 @@ def is_bcache():
6
7 @hook("update-status")
8 def update_status():
9- changed = charms.reactive.helpers.is_data_changed(
10+ changed = charms.reactive.helpers.data_changed(
11 "detect_changes", get_base_inputs(), hash_type="sha256"
12 )
13 if changed:

Subscribers

People subscribed via source and target branches

to all changes: