Merge ~barryprice/charm-k8s-bind/+git/charm-k8s-bind:master into charm-k8s-bind:master

Proposed by Barry Price
Status: Merged
Approved by: Haw Loeung
Approved revision: 7bc29bfc27c4692b6a04e7caed5b45cf1b47939f
Merged at revision: 9d3c065259abb74a26fb4398b3af503af5ee3294
Proposed branch: ~barryprice/charm-k8s-bind/+git/charm-k8s-bind:master
Merge into: charm-k8s-bind:master
Diff against target: 68 lines (+18/-12)
2 files modified
README.md (+17/-11)
config.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Canonical IS Reviewers Pending
Review via email: mp+403767@code.launchpad.net

Commit message

Update OCI tag info, document behavioural change

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 9d3c065259abb74a26fb4398b3af503af5ee3294

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/README.md b/README.md
index 3e31d97..8a2b7e6 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,7 @@
1# Bind Operator1# Bind Operator
22
3A Juju charm deploying Bind, configurable to use a git repository for its configuration files.3A Juju charm deploying Bind, configurable to use a git repository for its
4configuration files.
45
5## Overview6## Overview
67
@@ -19,19 +20,22 @@ To deploy this charm in a juju k8s model:
19juju deploy bind-k8s20juju deploy bind-k8s
20```21```
21The charm will deploy bind with its stock Ubuntu package configuration, which22The charm will deploy bind with its stock Ubuntu package configuration, which
22will forward all queries to root name servers.23will forward all queries to root name servers. DNSSEC is enabled by default.
2324
24DNSSEC is also enabled by default.25The charm will also make one change from those defaults, to allow traffic from
26all local (RFC1918) networks.
27
28If the operator really wants the stock defaults, which only allow traffic from
29localhost, this feature can be disabled via:
30
31```
32$ juju config bind-k8s enable_rfc1918_recursion=false
33```
2534
26Custom config can be deployed by setting the `custom_config_repo` option to35Custom config can be deployed by setting the `custom_config_repo` option to
27point to a Git repository containing a valid set of configuration files with36point to a Git repository containing a valid set of configuration files with
28which to populate the `/etc/bind/` directory within the pod(s).37which to populate the `/etc/bind/` directory within the pod(s).
2938
30Since bind won't allow recursion from external clients by default, to allow
31easy testing, you can use [a repo with a copy of the stock config, modified to allow recursion from all RFC1918 networks](https://code.launchpad.net/~barryprice/junk/+git/etc-bind-stock-config-with-all-rfc1918-nets-allowed):
32```
33juju config bind-k8s custom_config_repo=https://git.launchpad.net/~barryprice/junk/+git/etc-bind-stock-config-with-all-rfc1918-nets-allowed
34```
35Once the application is ready, you should be able to query the App's IP address39Once the application is ready, you should be able to query the App's IP address
36(not the Unit addresses) directly from your local machine:40(not the Unit addresses) directly from your local machine:
3741
@@ -54,6 +58,8 @@ $
5458
55## Known Issues59## Known Issues
5660
57This charm is unable to provide an ingress to route TCP and UDP traffic to the61This charm is unable to provide an ingress service to route TCP and UDP traffic
58pods due to [LP#1889703](https://bugs.launchpad.net/juju/+bug/1889703). This is62to the pods due to [LP#1889703](https://bugs.launchpad.net/juju/+bug/1889703).
59also being tracked as [a bug against the charm itself](https://bugs.launchpad.net/charm-k8s-bind/+bug/1889746).63
64This is also being tracked as [a bug against the charm
65itself](https://bugs.launchpad.net/charm-k8s-bind/+bug/1889746).
diff --git a/config.yaml b/config.yaml
index fcad409..9b1de1d 100644
--- a/config.yaml
+++ b/config.yaml
@@ -5,7 +5,7 @@ options:
5 The location of the image to use, e.g. "registry.example.com/bind:v1".5 The location of the image to use, e.g. "registry.example.com/bind:v1".
66
7 This setting is required.7 This setting is required.
8 default: "bindcharmers/bind:edge"8 default: "bindcharmers/bind:v1.0-20.04_edge"
9 bind_image_username:9 bind_image_username:
10 type: string10 type: string
11 description: "Username to use for the configured image registry, if required"11 description: "Username to use for the configured image registry, if required"

Subscribers

People subscribed via source and target branches

to all changes: