Merge ~barryprice/charm-k8s-bind/+git/charm-k8s-bind:master into charm-k8s-bind:master

Proposed by Barry Price
Status: Merged
Approved by: Haw Loeung
Approved revision: 7bc29bfc27c4692b6a04e7caed5b45cf1b47939f
Merged at revision: 9d3c065259abb74a26fb4398b3af503af5ee3294
Proposed branch: ~barryprice/charm-k8s-bind/+git/charm-k8s-bind:master
Merge into: charm-k8s-bind:master
Diff against target: 68 lines (+18/-12)
2 files modified
README.md (+17/-11)
config.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Canonical IS Reviewers Pending
Review via email: mp+403767@code.launchpad.net

Commit message

Update OCI tag info, document behavioural change

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 9d3c065259abb74a26fb4398b3af503af5ee3294

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.md b/README.md
2index 3e31d97..8a2b7e6 100644
3--- a/README.md
4+++ b/README.md
5@@ -1,6 +1,7 @@
6 # Bind Operator
7
8-A Juju charm deploying Bind, configurable to use a git repository for its configuration files.
9+A Juju charm deploying Bind, configurable to use a git repository for its
10+configuration files.
11
12 ## Overview
13
14@@ -19,19 +20,22 @@ To deploy this charm in a juju k8s model:
15 juju deploy bind-k8s
16 ```
17 The charm will deploy bind with its stock Ubuntu package configuration, which
18-will forward all queries to root name servers.
19+will forward all queries to root name servers. DNSSEC is enabled by default.
20
21-DNSSEC is also enabled by default.
22+The charm will also make one change from those defaults, to allow traffic from
23+all local (RFC1918) networks.
24+
25+If the operator really wants the stock defaults, which only allow traffic from
26+localhost, this feature can be disabled via:
27+
28+```
29+$ juju config bind-k8s enable_rfc1918_recursion=false
30+```
31
32 Custom config can be deployed by setting the `custom_config_repo` option to
33 point to a Git repository containing a valid set of configuration files with
34 which to populate the `/etc/bind/` directory within the pod(s).
35
36-Since bind won't allow recursion from external clients by default, to allow
37-easy testing, you can use [a repo with a copy of the stock config, modified to allow recursion from all RFC1918 networks](https://code.launchpad.net/~barryprice/junk/+git/etc-bind-stock-config-with-all-rfc1918-nets-allowed):
38-```
39-juju config bind-k8s custom_config_repo=https://git.launchpad.net/~barryprice/junk/+git/etc-bind-stock-config-with-all-rfc1918-nets-allowed
40-```
41 Once the application is ready, you should be able to query the App's IP address
42 (not the Unit addresses) directly from your local machine:
43
44@@ -54,6 +58,8 @@ $
45
46 ## Known Issues
47
48-This charm is unable to provide an ingress to route TCP and UDP traffic to the
49-pods due to [LP#1889703](https://bugs.launchpad.net/juju/+bug/1889703). This is
50-also being tracked as [a bug against the charm itself](https://bugs.launchpad.net/charm-k8s-bind/+bug/1889746).
51+This charm is unable to provide an ingress service to route TCP and UDP traffic
52+to the pods due to [LP#1889703](https://bugs.launchpad.net/juju/+bug/1889703).
53+
54+This is also being tracked as [a bug against the charm
55+itself](https://bugs.launchpad.net/charm-k8s-bind/+bug/1889746).
56diff --git a/config.yaml b/config.yaml
57index fcad409..9b1de1d 100644
58--- a/config.yaml
59+++ b/config.yaml
60@@ -5,7 +5,7 @@ options:
61 The location of the image to use, e.g. "registry.example.com/bind:v1".
62
63 This setting is required.
64- default: "bindcharmers/bind:edge"
65+ default: "bindcharmers/bind:v1.0-20.04_edge"
66 bind_image_username:
67 type: string
68 description: "Username to use for the configured image registry, if required"

Subscribers

People subscribed via source and target branches

to all changes: