Merge ~barryprice/charm-k8s-bind/+git/charm-k8s-bind:master into charm-k8s-bind:master

Proposed by Barry Price
Status: Merged
Approved by: Tom Haddon
Approved revision: 0d4409284f7a4b9adb8df4efeee500de42be3f5f
Merged at revision: 9216c8f618481053185bba96c5b32e6478345f61
Proposed branch: ~barryprice/charm-k8s-bind/+git/charm-k8s-bind:master
Merge into: charm-k8s-bind:master
Diff against target: 70 lines (+17/-13)
2 files modified
README.md (+15/-11)
config.yaml (+2/-2)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Canonical IS Reviewers Pending
Review via email: mp+393289@code.launchpad.net

Commit message

Use the Dockerhub image by default, update the README accordingly

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 9216c8f618481053185bba96c5b32e6478345f61

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/README.md b/README.md
index a5ba4ae..ff1c869 100644
--- a/README.md
+++ b/README.md
@@ -26,28 +26,32 @@ Notes for deploying a test setup locally using microk8s:
26 sudo snap install juju-wait --classic26 sudo snap install juju-wait --classic
27 sudo snap install microk8s --classic27 sudo snap install microk8s --classic
28 sudo snap alias microk8s.kubectl kubectl28 sudo snap alias microk8s.kubectl kubectl
29 sudo snap install charmcraft
30 git clone https://git.launchpad.net/charm-k8s-bind
31 make bind.charm
3229
33 microk8s.reset # Warning! Clean slate!30 microk8s.reset # Warning! Clean slate!
34 microk8s.enable dns dashboard registry storage31 microk8s.enable dns dashboard registry storage
35 microk8s.status --wait-ready32 microk8s.status --wait-ready
36 microk8s.config | juju add-k8s myk8s --client33 microk8s.config | juju add-k8s myk8s --client
3734
38 # Build your Bind image
39 make build-image
40 docker push localhost:32000/bind
41
42 juju bootstrap myk8s35 juju bootstrap myk8s
43 juju add-model bind-test36 juju add-model bind-test
44 juju deploy ./bind.charm --config bind_image_path=localhost:32000/bind:latest bind37
38 #1. Either deploy with the default image from Dockerhub:
39 juju deploy cs:~bind-charmers/bind
40
41 #2. Or optionally build your own image locally and deploy with that
42 sudo snap install charmcraft
43 git clone https://git.launchpad.net/charm-k8s-bind
44 cd charm-k8s-bind
45 make image-build
46 docker push localhost:32000/bind
47 juju deploy cs:~bind-charmers/bind --config bind_image_path=localhost:32000/bind:latest bind
48
45 juju wait49 juju wait
46 juju status50 juju status
4751
48Assuming you're using the image as built locally from this repo, the charm will52Assuming you're using the image from dockerhub, or an image built locally from
49deploy bind with its stock Ubuntu package configuration, which will forward all53this repo without changes, the charm will deploy bind with its stock Ubuntu
50queries to root name servers.54package configuration, which will forward all queries to root name servers.
5155
52DNSSEC is also enabled by default.56DNSSEC is also enabled by default.
5357
diff --git a/config.yaml b/config.yaml
index 408ae9d..214ab0c 100644
--- a/config.yaml
+++ b/config.yaml
@@ -5,7 +5,7 @@ options:
5 The location of the image to use, e.g. "registry.example.com/bind:v1".5 The location of the image to use, e.g. "registry.example.com/bind:v1".
66
7 This setting is required.7 This setting is required.
8 default: ""8 default: "bindcharmers/bind:edge"
9 bind_image_username:9 bind_image_username:
10 type: string10 type: string
11 description: "Username to use for the configured image registry, if required"11 description: "Username to use for the configured image registry, if required"
@@ -40,7 +40,7 @@ options:
40 description: |40 description: |
41 Proxy address to set in the environment, e.g. http://192.168.1.1:808041 Proxy address to set in the environment, e.g. http://192.168.1.1:8080
42 Used to clone the configuration files from custom_config_repo, if set.42 Used to clone the configuration files from custom_config_repo, if set.
43 If a username/password is required, they can be embedded in the proxy 43 If a username/password is required, they can be embedded in the proxy
44 address e.g. http://username:password@192.168.1.1:808044 address e.g. http://username:password@192.168.1.1:8080
45 Traffic is expected to be HTTPS, but this will also work for HTTP.45 Traffic is expected to be HTTPS, but this will also work for HTTP.
46 default: ""46 default: ""

Subscribers

People subscribed via source and target branches

to all changes: