Merge ~barryprice/charm-k8s-bind/+git/charm-k8s-bind:master into charm-k8s-bind:master

Proposed by Barry Price
Status: Merged
Approved by: Tom Haddon
Approved revision: 0d4409284f7a4b9adb8df4efeee500de42be3f5f
Merged at revision: 9216c8f618481053185bba96c5b32e6478345f61
Proposed branch: ~barryprice/charm-k8s-bind/+git/charm-k8s-bind:master
Merge into: charm-k8s-bind:master
Diff against target: 70 lines (+17/-13)
2 files modified
README.md (+15/-11)
config.yaml (+2/-2)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Canonical IS Reviewers Pending
Review via email: mp+393289@code.launchpad.net

Commit message

Use the Dockerhub image by default, update the README accordingly

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 9216c8f618481053185bba96c5b32e6478345f61

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.md b/README.md
2index a5ba4ae..ff1c869 100644
3--- a/README.md
4+++ b/README.md
5@@ -26,28 +26,32 @@ Notes for deploying a test setup locally using microk8s:
6 sudo snap install juju-wait --classic
7 sudo snap install microk8s --classic
8 sudo snap alias microk8s.kubectl kubectl
9- sudo snap install charmcraft
10- git clone https://git.launchpad.net/charm-k8s-bind
11- make bind.charm
12
13 microk8s.reset # Warning! Clean slate!
14 microk8s.enable dns dashboard registry storage
15 microk8s.status --wait-ready
16 microk8s.config | juju add-k8s myk8s --client
17
18- # Build your Bind image
19- make build-image
20- docker push localhost:32000/bind
21-
22 juju bootstrap myk8s
23 juju add-model bind-test
24- juju deploy ./bind.charm --config bind_image_path=localhost:32000/bind:latest bind
25+
26+ #1. Either deploy with the default image from Dockerhub:
27+ juju deploy cs:~bind-charmers/bind
28+
29+ #2. Or optionally build your own image locally and deploy with that
30+ sudo snap install charmcraft
31+ git clone https://git.launchpad.net/charm-k8s-bind
32+ cd charm-k8s-bind
33+ make image-build
34+ docker push localhost:32000/bind
35+ juju deploy cs:~bind-charmers/bind --config bind_image_path=localhost:32000/bind:latest bind
36+
37 juju wait
38 juju status
39
40-Assuming you're using the image as built locally from this repo, the charm will
41-deploy bind with its stock Ubuntu package configuration, which will forward all
42-queries to root name servers.
43+Assuming you're using the image from dockerhub, or an image built locally from
44+this repo without changes, the charm will deploy bind with its stock Ubuntu
45+package configuration, which will forward all queries to root name servers.
46
47 DNSSEC is also enabled by default.
48
49diff --git a/config.yaml b/config.yaml
50index 408ae9d..214ab0c 100644
51--- a/config.yaml
52+++ b/config.yaml
53@@ -5,7 +5,7 @@ options:
54 The location of the image to use, e.g. "registry.example.com/bind:v1".
55
56 This setting is required.
57- default: ""
58+ default: "bindcharmers/bind:edge"
59 bind_image_username:
60 type: string
61 description: "Username to use for the configured image registry, if required"
62@@ -40,7 +40,7 @@ options:
63 description: |
64 Proxy address to set in the environment, e.g. http://192.168.1.1:8080
65 Used to clone the configuration files from custom_config_repo, if set.
66- If a username/password is required, they can be embedded in the proxy
67+ If a username/password is required, they can be embedded in the proxy
68 address e.g. http://username:password@192.168.1.1:8080
69 Traffic is expected to be HTTPS, but this will also work for HTTP.
70 default: ""

Subscribers

People subscribed via source and target branches

to all changes: