Code review comment for ~barryprice/charm-canonical-livepatch/+git/canonical-livepatch-charm:master

Revision history for this message
Stuart Bishop (stub) wrote :

I guess at least with livepatch being a snap we don't have to worry about supporting the old format. Might be worth letting them know that this output is being scraped and if they change it they break things.

The patch looks good. I see a lot of hookenv.log() calls logging errors at the default INFO level, which you might want to fix. I'm unsure how much it matters with current Juju.

review: Approve

« Back to merge proposal