Merge ~barryprice/+git/cleanup:master into ~hloeung/+git/cleanup:master

Proposed by Barry Price
Status: Merged
Merged at revision: f7e606ac6b45e60d68eb5217099d136ad069342a
Proposed branch: ~barryprice/+git/cleanup:master
Merge into: ~hloeung/+git/cleanup:master
Diff against target: 45 lines (+5/-5)
3 files modified
README (+1/-1)
actions.py (+3/-3)
cleanup (+1/-1)
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Review via email: mp+393160@code.launchpad.net

Commit message

'apt-get autoclean' doesn't remove much - 'apt-get clean' removes all locally downloaded .deb files, which are unlikely to be needed again (and can be re-downloaded in any case)

To post a comment you must log in.
Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/README b/README
index 897a35e..d7847ab 100644
--- a/README
+++ b/README
@@ -30,7 +30,7 @@ Optional actions
30 contains:30 contains:
31 Unattended-Upgrade::Remove-Unused-Dependencies "true";31 Unattended-Upgrade::Remove-Unused-Dependencies "true";
32 to mitigate https://bugs.launchpad.net/bugs/135709332 to mitigate https://bugs.launchpad.net/bugs/1357093
33- Run apt-get autoremove & apt-get autoclean.33- Run apt-get autoremove & apt-get clean.
34- ksplice: Remove any directory in /var/cache/uptrack/Linux/x64_64 which34- ksplice: Remove any directory in /var/cache/uptrack/Linux/x64_64 which
35 doesn't match the running kernel.35 doesn't match the running kernel.
36- Remove all kernel and kernel header packages which aren't either the running36- Remove all kernel and kernel header packages which aren't either the running
diff --git a/actions.py b/actions.py
index 28e3c1d..7413ddc 100644
--- a/actions.py
+++ b/actions.py
@@ -512,11 +512,11 @@ class AptAutoremove(AptAction):
512 return "Checking for removable packages"512 return "Checking for removable packages"
513513
514514
515class AptAutoclean(AptAction):515class AptClean(AptAction):
516 """Run apt-get autoclean"""516 """Run apt-get clean"""
517517
518 def __init__(self, options):518 def __init__(self, options):
519 AptAction.__init__(self, options, 'autoclean', re.compile('Del '))519 AptAction.__init__(self, options, 'clean', re.compile('Del '))
520520
521 def check(self, options):521 def check(self, options):
522 if self.run_apt(options):522 if self.run_apt(options):
diff --git a/cleanup b/cleanup
index e3b21ee..8b6ae3a 100755
--- a/cleanup
+++ b/cleanup
@@ -152,7 +152,7 @@ def main():
152152
153 optional = [153 optional = [
154 actions.AptAutoremove(options),154 actions.AptAutoremove(options),
155 actions.AptAutoclean(options),155 actions.AptClean(options),
156 actions.InstallRemoveUnusedDependencies(options),156 actions.InstallRemoveUnusedDependencies(options),
157 actions.CleanKernels(options),157 actions.CleanKernels(options),
158 actions.CleanUptrackCache(options),158 actions.CleanUptrackCache(options),

Subscribers

People subscribed via source and target branches

to all changes: