Merge ~barryprice/+git/cleanup:master into ~hloeung/+git/cleanup:master

Proposed by Barry Price
Status: Merged
Merged at revision: f7e606ac6b45e60d68eb5217099d136ad069342a
Proposed branch: ~barryprice/+git/cleanup:master
Merge into: ~hloeung/+git/cleanup:master
Diff against target: 45 lines (+5/-5)
3 files modified
README (+1/-1)
actions.py (+3/-3)
cleanup (+1/-1)
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Review via email: mp+393160@code.launchpad.net

Commit message

'apt-get autoclean' doesn't remove much - 'apt-get clean' removes all locally downloaded .deb files, which are unlikely to be needed again (and can be re-downloaded in any case)

To post a comment you must log in.
Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README b/README
2index 897a35e..d7847ab 100644
3--- a/README
4+++ b/README
5@@ -30,7 +30,7 @@ Optional actions
6 contains:
7 Unattended-Upgrade::Remove-Unused-Dependencies "true";
8 to mitigate https://bugs.launchpad.net/bugs/1357093
9-- Run apt-get autoremove & apt-get autoclean.
10+- Run apt-get autoremove & apt-get clean.
11 - ksplice: Remove any directory in /var/cache/uptrack/Linux/x64_64 which
12 doesn't match the running kernel.
13 - Remove all kernel and kernel header packages which aren't either the running
14diff --git a/actions.py b/actions.py
15index 28e3c1d..7413ddc 100644
16--- a/actions.py
17+++ b/actions.py
18@@ -512,11 +512,11 @@ class AptAutoremove(AptAction):
19 return "Checking for removable packages"
20
21
22-class AptAutoclean(AptAction):
23- """Run apt-get autoclean"""
24+class AptClean(AptAction):
25+ """Run apt-get clean"""
26
27 def __init__(self, options):
28- AptAction.__init__(self, options, 'autoclean', re.compile('Del '))
29+ AptAction.__init__(self, options, 'clean', re.compile('Del '))
30
31 def check(self, options):
32 if self.run_apt(options):
33diff --git a/cleanup b/cleanup
34index e3b21ee..8b6ae3a 100755
35--- a/cleanup
36+++ b/cleanup
37@@ -152,7 +152,7 @@ def main():
38
39 optional = [
40 actions.AptAutoremove(options),
41- actions.AptAutoclean(options),
42+ actions.AptClean(options),
43 actions.InstallRemoveUnusedDependencies(options),
44 actions.CleanKernels(options),
45 actions.CleanUptrackCache(options),

Subscribers

People subscribed via source and target branches

to all changes: