Code review comment for lp:~barry/ubuntu/natty/python-keyring/bug-686257

Revision history for this message
Barry Warsaw (barry) wrote :

Sorry, I don't quite understand the comment. Do you mean that the tests aren't being installed or shouldn't be installed? Because I think they are installed, and I kind of think they should be. :)

There was a debate recently on one of the Python mailing lists about this (I forget which one, but probably either distutils or the testing sig) and there were definitely opinions on both sides. I'm personally of the opinion that tests should be installed, for various reasons:

* They can serve as documentation to users
* They can be run by end users to verify a package works properly
* They rarely take up much additional space
* It's usually easier to include the tests than not when they are shipped upstream as a subpackage

Others disagree and it can be decided on a case-by-case basis, but in this case, I see no harm and some potential good, so I would continue to include the tests.

« Back to merge proposal