Code review comment for lp:~barry/ubuntu/natty/libfsoresource/618809-ftbfs

Revision history for this message
Artur Rona (ari-tczew) wrote :

I noticed that there is no patch system. You can check it in source directory via command 'what-patch'. You should patch configure.ac directly. Automatically, there is no place to adding DEP3 tags. Sorry for that, I didn't check before whether patch system is used. Please also drop simple-patchsys.mk from d/rules.

However, would be nice to be more verbose in debian/changelog, I suggest:

* debian/control, configure.ac:
  - Transition from libvala-dev to libvala-0.10-dev. (LP: #618809)
* debian/rules: Run autoreconf due to touched configure.ac.

review: Needs Fixing

« Back to merge proposal