Ubuntu
libfsoframework package

Code review comment for lp:~barry/ubuntu/natty/libfsoframework/618809-ftbfs

  1. Natty (11.04)
  2. 618809-ftbfs
  3. Merge into natty
Revision history for this message
Barry Warsaw (barry) wrote :

> You are patching configure.c by 01-pkg-config-for-vala-0.10.patch, so please
> update debian/changelog:
>
> * 01-pkg-config-for-vala-0.10.patch, debian/control:
> - Transition from libvala-dev to libvala-0.10-dev. (LP: #618809)
> * debian/control:
> - Build-Depends on libtool since it's required for autoreconf.
> * debian/rules: Run autoreconf before building.
>
> Please don't forget that sentence ends by dot.
>
> You used wrong tag in patch:
> Bug: https://launchpad.net/bugs/618809
> should be:
> Bug-Ubuntu: https://launchpad.net/bugs/618809

Fixed & pushed.

« Back to merge proposal