Code review comment for lp:~barry/ubuntu/natty/claws-mail/bug-724416

Revision history for this message
Evan Broder (broder) wrote :

This patch looks fine, but ugh the claws-mail branch is thoroughly massive. This coffeeshop's wifi isn't cutting it.

In the mean time, the one issue I see is that 60upstream_bug_2325_fix.patch doesn't have a DEP-3 header, which is a better place to put patch provenance information than the changelog.

I'm going to take another look at this when I get home. In the interests of expediency, there's enough information here that I'll go ahead and write up the DEP-3 header when I do so, if you haven't had a chance to by then.

review: Needs Fixing

« Back to merge proposal