Merge lp:~barry/ubuntu/lucid/update-manager/fix-511628 into lp:ubuntu/lucid/update-manager

Proposed by Barry Warsaw
Status: Merged
Merge reported by: Barry Warsaw
Merged at revision: not available
Proposed branch: lp:~barry/ubuntu/lucid/update-manager/fix-511628
Merge into: lp:ubuntu/lucid/update-manager
Diff against target: 25 lines (+7/-0)
2 files modified
UpdateManager/SafeGConfClient.py (+1/-0)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~barry/ubuntu/lucid/update-manager/fix-511628
Reviewer Review Type Date Requested Status
Michael Vogt Approve
James Westby (community) Abstain
Review via email: mp+21208@code.launchpad.net

Description of the change

Fixes the obvious NameError. Hopefully this time the merge proposal will be sane ;).

To post a comment you must log in.
258. By Barry Warsaw

Fix obvious NameError by adding a missing import. (LP: #537250)

Revision history for this message
James Westby (james-w) :
review: Abstain
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks Barry, you rock!

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

(and I should have more tests)

Revision history for this message
Barry Warsaw (barry) wrote :

Thanks Michael. Will you merge the branch or is that something I can do?

Revision history for this message
Michael Vogt (mvo) wrote :

Its merged and uploaded, currently waiting for approval. I was not able to merge it into trunk because the branches have no common ancestor. But I assume with the upload it will be auto-imported and LP notices that its merged. Otherwise we will have to mark it merged manually.

Revision history for this message
James Westby (james-w) wrote :

On Sat, 13 Mar 2010 07:49:23 -0000, Michael Vogt <email address hidden> wrote:
> Its merged and uploaded, currently waiting for approval. I was not able to merge it into trunk because the branches have no common ancestor. But I assume with the upload it will be auto-imported and LP notices that its merged. Otherwise we will have to mark it merged manually.

You will have to do this manually while there is no common ancestry.

Thanks,

James

Revision history for this message
Barry Warsaw (barry) wrote :

Looking at the trunk, I believe you've done this Michael, so I'm marking the branch as merged. Let me know if I'm mistaken.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'UpdateManager/SafeGConfClient.py'
2--- UpdateManager/SafeGConfClient.py 2010-01-12 18:15:52 +0000
3+++ UpdateManager/SafeGConfClient.py 2010-03-12 15:06:27 +0000
4@@ -20,6 +20,7 @@
5 # USA
6
7 import gconf
8+import gobject
9
10 class SafeGConfClient(object):
11 """A gconfclient that does not crash if gconf is not avaialble"""
12
13=== modified file 'debian/changelog'
14--- debian/changelog 2010-03-08 20:58:44 +0000
15+++ debian/changelog 2010-03-12 15:06:27 +0000
16@@ -1,3 +1,9 @@
17+update-manager (1:0.133ubuntu1) lucid; urgency=low
18+
19+ * Fix obvious NameError by adding a missing import. (LP: #537250)
20+
21+ -- Barry Warsaw <barry@canonical.com> Thu, 11 Mar 2010 21:23:25 -0500
22+
23 update-manager (1:0.133) lucid; urgency=low
24
25 [ Michael Vogt ]

Subscribers

People subscribed via source and target branches

to all changes: