Code review comment for lp:~barry/ubuntu-sso-client/lp1077087

Revision history for this message
Barry Warsaw (barry) wrote :

python-oauthlib 0.3.5 is now in raring, and I've updated this branch against trunk. It should be ready for review and merging now.

Note that I get 5 test errors, but I get these in the unaltered trunk branch too, so my changes should not be the cause.

ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_requested_creds_bad_details
ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_requested_creds_bad_details_everywhere
ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_requested_creds_bad_details_user
ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_auth_proxy_is_used_creds_requested
ubuntu_sso.utils.webclient.tests.test_webclient.BasicProxyTestCase.test_authenticated_proxy_is_used

« Back to merge proposal