Code review comment for lp:~barry/ubuntu-packaging-guide/udd-update

On Wed, Feb 01, 2012 at 10:39:57AM -0500, Barry Warsaw wrote:
> On Feb 01, 2012, at 03:35 PM, Jelmer Vernooij wrote:
> >"bzr dep3-patch" can often be a good alternative to "bzr diff -p ..." because
> >it will also generate the relevant DEP3 headers (including whether or not the
> >changes are upstream, the authors, etc). It doesn't work with uncommitted
> >changes in the current tree yet, perhaps we should add that.
> Thanks, I didn't know about that command. Do you think it would make things
> clearer to mention it? Or, would it be possible to tweak the diff prefix
> default when in a source branch?
For the moment, I think just "bzr diff -p" is more sensible. Once
dep3-patch works well enough we could mention that, or integrate it
into "bzr diff" (e.g. "bzr diff --format=dep3").

We could automatically enable -p in source package branches, but it
might be confusing for users if that default changed from branch to
branch, and it's unclear why the default is different. What do you think ?

Cheers,

Jelmer