Code review comment for lp:~barry/ubuntu-packaging-guide/udd-update

On Feb 01, 2012, at 03:07 AM, Martin Pool wrote:

>Thanks so much, this is great to bring it up to date and improve the docs.
>
>I've read through it. It's easy to miss things with just a
>line-by-line diff, but I think there's just a few tweaks.
>
>> + $ bzr merge debianlp:squeeze/tomboy
>
>missing a space there

Sorry, I don't see the missing space. I tested the command as written above.

>It may be worth mentioning people need bzr and its plugins from either
>Oneiric (Precise?), or from the bzr ppa, to get all the features you
>describe.

Good point. I've added a footnote taking the version numbers from Jelmer's
email to the UDD mailing list.

>+ $ bzr merge debianlp:squeeze/tomboy
>
>How does 'debianlp:' differ from 'debian:'? Maybe you could explain?

I think there actually is no debian: prefix. IIRC, debianlp: was chosen to
make it clear that it's grabbing the branch from Debian imported into
Launchpad. It was felt that debian: alone would imply grabbing the branch
from the Debian VCS.

>-.. This section seems a bit too casual, and assumes to much prior
>knowledge (re: use of "of course").
>-
>-You could of course just use `dh_make(8)` to get things going, or you could
>-use `bzr dh-make`. The latter might provide some benefits, and can be run
>-like so from inside your branch::
>+You could use the `dh_make` command to get things going, or similiarly the
>+`bzr dh-make`. The latter might provide some benefits, and can be run like so
>+from inside your branch::
>
>should be double-backticks.

Fixed, thanks (along with the typo :).

>+ The
>+``bzr tag`` command will do this for you automatically::
>
> $ bzr tag
>
>That is good to mention but perhaps for clarity you should say it does
>this when you give it no argument.

Fixed, thanks.