Merge lp:~barry/pkgme/test-fixes into lp:pkgme
Proposed by
Barry Warsaw
Status: | Merged |
---|---|
Merged at revision: | 42 |
Proposed branch: | lp:~barry/pkgme/test-fixes |
Merge into: | lp:pkgme |
Diff against target: |
186 lines (+63/-32) 6 files modified
pkgme/backend.py (+41/-4) pkgme/testing.py (+14/-0) pkgme/tests/__init__.py (+0/-19) pkgme/tests/test_python_backend.py (+2/-4) pkgme/tests/test_vala_backend.py (+5/-5) setup.py (+1/-0) |
To merge this branch: | bzr merge lp:~barry/pkgme/test-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby | Approve | ||
Review via email: mp+44121@code.launchpad.net |
Description of the change
This fixes all the tests for me.
To post a comment you must log in.
80 + def __repr__(self): self.path)
81 + return '<TempdirFixture: {0}'.format(
82 +
Missing ">"?
92 +def command_ exists( command_ name): call(command_ name)
93 + try:
94 + subprocess.
95 + except OSError:
96 + # Assume command not found.
97 + return False
98 + else:
99 + return True
Could we have this be a str(e)/None interface or similar? That way we can include the reason in the skip message, and people won't be confused when it is saying that vala-dep-scanner isn't installed when it's just not executable or something.
105 -import unittest tests.test_ backend' , tests.test_ distutils_ command' , tests.test_ info_elements' , tests.test_ package_ files', tests.test_ project_ info', tests.test_ python_ backend' , tests.test_ script' , tests.test_ template_ file', tests.test_ vala_backend' , tests.test_ write', tests.test_ write_packaging ', TestLoader( ) loadTestsFromNa mes(module_ names)
106 -
107 -def test_suite():
108 - module_names = [
109 - 'pkgme.
110 - 'pkgme.
111 - 'pkgme.
112 - 'pkgme.
113 - 'pkgme.
114 - 'pkgme.
115 - 'pkgme.
116 - 'pkgme.
117 - 'pkgme.
118 - 'pkgme.
119 - 'pkgme.
120 - ]
121 - loader = unittest.
122 - suite = loader.
123 - return suite
Can we keep this? I use testr to run the tests, and I don't think there's
a way to get subunit output from "setup.py test"?
Otherwise this change looks good to me.
Thanks,
James