Code review comment for lp:~barry/oneconf/lp1088536

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

This looks good to me!
small things to change IMHO:
- can you move debhelper to version 9 instead of 8? Let's use the latest and greatest :)
- I think short description should be different between binary package, maybe adding pythonX lib?
- We should add the tests (and so test.test_daemon) as an autopkg tests to ensure depends don't break oneconf :)

Thanks a lot!

review: Needs Fixing

« Back to merge proposal