Code review comment for lp:~barry/mailman/py26

Revision history for this message
Mark Sapiro (msapiro) wrote :

So far, I've just eyeballed the diffs, but they look good with one exception. In configure.in, minimum Python version should be 2.4 as the sibling lists feature in CalcRecips.py uses sets.

Also, paths.py.in suppressed the string exception warning for python 2.5 with

    # Supress Python 2.5 warning about string exceptions.
    filterwarnings('ignore', '.* string exception', DeprecationWarning)

which can now be removed.

I still intend to do an actual build of the branch and test it.

review: Abstain (code)

« Back to merge proposal