Code review comment for lp:~barry/lazr.config/bug-310619

Revision history for this message
Barry Warsaw (barry) wrote :

This adds the .master idea as described in the bug.

It also fixes Python 2.6 compatibility. I've tested it with Python 2.4, 2.5 and 2.6.

The one thing that is a bit questionable is the need to add a .clone() method to SectionSchema so that the 'name' could be overridden. Otherwise, there's no way to get the section name from the config instead of the schema (i.e. the section.master name).

« Back to merge proposal